Skip to content

Command buffers#78

Merged
Gr-i-niy merged 19 commits into
mainfrom
command_buffers
Jun 3, 2025
Merged

Command buffers#78
Gr-i-niy merged 19 commits into
mainfrom
command_buffers

Conversation

@Fra1sse

@Fra1sse Fra1sse commented Mar 22, 2025

Copy link
Copy Markdown
Collaborator

Перенесены функции с Command buffers в файлы vk_command_buffers.cpp/h

@anunknowperson

Copy link
Copy Markdown
Owner
  • исправить мерж конфликт
  • замеить VK* на ссылки

Comment thread src/graphics/vulkan/vk_engine.cpp
Comment thread src/graphics/vulkan/vk_engine.cpp Outdated

@anunknowperson anunknowperson left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/graphics/vulkan/vk_engine.cpp Outdated
Comment thread src/graphics/vulkan/vk_engine.cpp Outdated
Comment thread src/graphics/vulkan/vk_engine.cpp Outdated
@anunknowperson

Copy link
Copy Markdown
Owner
  1. *this передавать можно, но в параметрах функции должны быть ссылки.
  2. нужно держать ссылку на VulkanEngine& в классе command buffers в приватных полях, передать туда в init_commands анпрмиер

Comment thread src/graphics/vulkan/vk_engine.cpp
Comment thread src/graphics/vulkan/vk_command_buffers.cpp Outdated
Comment thread src/graphics/vulkan/vk_command_buffers.cpp Outdated
Comment thread src/graphics/vulkan/vk_command_buffers.cpp Outdated
Comment thread src/graphics/vulkan/vk_command_buffers.cpp Outdated
Comment thread src/include/graphics/vulkan/vk_command_buffers.h Outdated
Comment thread src/include/graphics/vulkan/vk_command_buffers.h Outdated
Comment thread src/include/graphics/vulkan/vk_engine.h Outdated
Comment thread src/include/graphics/vulkan/vk_engine.h Outdated
Comment thread src/include/graphics/vulkan/vk_engine.h Outdated
@maybenotilya

Copy link
Copy Markdown

А ну и как обычно огромное спасибо талантливой Ксении за вклад в развитие нашего проекта

@maybenotilya

Copy link
Copy Markdown

Hey! Any updates on this one?

@Gr-i-niy Gr-i-niy merged commit b97b7f2 into main Jun 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants