Fix #226

[anweiss]

Fix #226

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

PR Overview

This PR updates range validation logic for both JSON and CBOR validators and adds new tests to verify the behavior of inclusive and exclusive ranges. Key changes include adjustments to error messages, numeric comparisons, type conversions, and updated boundary test expectations.

• Updated import statements in tests to include additional functionality needed for range operator tests.
• Refactored range validation logic in JSON and CBOR validators to consistently treat inclusive lower bounds and exclusive upper bounds for the "..." range.
• Added new tests for validating both integer and float range operators as well as string length range checks via the .size control operator.

Changes

File	Description
tests/cbor.rs	Added tests for range validations using CBORValidator and updated imports.
src/validator/json.rs	Improved range comparison logic and error messages; fixed type conversion for string length comparisons.
src/validator/cbor.rs	Adjusted range checks and updated boundary test expectations to align with new validation rules.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/validator/json.rs:889

• [nitpick] The updated error message for exclusive integer ranges is clearer; please verify that the use of '<' for the upper bound across all numeric types is consistent with the CDDL specification.

format!("expected integer to be in range {} <= value < {}, got {}", l, u, self.json)

src/validator/json.rs:959

• [nitpick] Ensure that converting the string length to u64 is consistently applied and does not mask potential type mismatches on platforms where usize and u64 differ.

let len = s.len() as u64; // Fix: Convert len to u64

src/validator/cbor.rs:3896

• [nitpick] The change in the boundary test now expects a 16-byte CBOR to pass validation; please confirm that this update is in line with the intended behavior defined by the CDDL spec.

// Test boundary case (16 bytes - should pass)

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more