Skip to content

Conversation

@jmetrikat
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the auth create command to use a positional argument instead of a flag-based approach, improving CLI usability by requiring the account name upfront rather than through an optional flag or interactive prompt. Additionally, it fixes a minor consistency issue in the apikey revoke command's error message.

Key changes:

  • Converted auth create command from using --name flag to requiring <name> as a positional argument
  • Removed interactive input prompts for account name
  • Updated all documentation to reflect the new positional argument syntax

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
cmd/auth/create/create.go Refactored to use positional argument via cmdutil.ExactArgs, removed --name flag and interactive input logic
cmd/auth/create/create_test.go Updated tests to verify positional argument usage and removed obsolete flag tests
cmd/auth/apikey/revoke/revoke.go Changed error message from "Id argument" to "id argument" for consistency with other commands
README.md Updated documentation examples to show <name> positional argument syntax for auth create and apikey create commands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jmetrikat jmetrikat merged commit f090b88 into main Dec 16, 2025
8 checks passed
@jmetrikat jmetrikat deleted the fix/positional-argument-consistentcy branch December 17, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants