[AMQ-9692] Support destination gc sweep of destinations with only wildcard consumers #1484
Conversation
mattrpav
changed the title
mattrpav
changed the title
mattrpav
force-pushed
the
AMQ-9692
branch
2 times, most recently
from
7f1115d to
8a4acfd
Compare
mattrpav
changed the title
| } | ||
| return isActive; | ||
|
|
||
| var destinationActive = true; |
There was a problem hiding this comment.
This is not very efficient because it may need to iterate through the consumers more than once. The way this is written, it may iterate through the consumers twice if both isGcWithNetworkConsumers() and isGcWithOnlyWildcardConsumers() is true.
What would make more sense is to only iterate through the consumers one time and use the predicate API to specify what you are looking for. You could build a predicate that look for either a network consumer, or not a wildcard consumer or some combination quite easily using https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/function/Predicate.html . This would also make it easy to expand the criteria in the future for other conditions.
If all the flags are off then we wouldn't need to iterate through the consumers at all.
No description provided.