-
Notifications
You must be signed in to change notification settings - Fork 17.9k
Neo4j SQL Misnomer #39860
Copy link
Copy link
Closed
Labels
area:providerskind:taskA task that needs to be completed as part of a larger issueA task that needs to be completed as part of a larger issueprovider:neo4j
Description
Activity
Metadata
Metadata
Assignees
Labels
area:providerskind:taskA task that needs to be completed as part of a larger issueA task that needs to be completed as part of a larger issueprovider:neo4j
Apache Airflow Provider(s)
neo4j
Versions of Apache Airflow Providers
No response
Apache Airflow version
2.9.0
Operating System
macOS
Deployment
Docker-Compose
Deployment details
No response
What happened
The Neo4jOperator makes reference to executing sql, when the actual query language is cypher. SQL is not used to query graph databases, and Neo4j doesn't support SQL.
This was confusing to me because I had to make sure that the operator in fact, was using CYPHER instead of sql.
The example here uses CYPHER, but passes it into the
sqlkwarg which is confusing/misleading/incorrect.What you think should happen instead
Instead of the operator taking a
sqlkwarg it should be renamed to cypher to match the actual query language being used.How to reproduce
Reproduce by looking at the source https://github.com/apache/airflow/blob/main/airflow/providers/neo4j/operators/neo4j.py#L31
Anything else
No response
Are you willing to submit PR?
Code of Conduct