-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add "core.task_runner" and "core.enable_xcom_pickling" to unsupported config check to command "airflow config lint" #45214
Merged
potiuk
merged 2 commits into
apache:main
from
astronomer:extend-airflow-config-lint-rules
Dec 31, 2024
Merged
feat(cli): add "core.task_runner" and "core.enable_xcom_pickling" to unsupported config check to command "airflow config lint" #45214
potiuk
merged 2 commits into
apache:main
from
astronomer:extend-airflow-config-lint-rules
Dec 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Dec 27, 2024
potiuk
reviewed
Dec 27, 2024
amoghrajesh
approved these changes
Dec 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 pending the clarification on xcom pickling, but I am sure you will handle that.
And thanks for code comments for each section, it helps!
…ing" check to command "airflow config lint"
4e77a49
to
065730d
Compare
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
… unsupported config check to command "airflow config lint" (apache#45214) * style(cli): add comments comments as deliminator * feat(cli): add removed "core.task_runner" and "core.enable_xcom_pickling" check to command "airflow config lint"
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 6, 2025
… unsupported config check to command "airflow config lint" (apache#45214) * style(cli): add comments comments as deliminator * feat(cli): add removed "core.task_runner" and "core.enable_xcom_pickling" check to command "airflow config lint"
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
… unsupported config check to command "airflow config lint" (apache#45214) * style(cli): add comments comments as deliminator * feat(cli): add removed "core.task_runner" and "core.enable_xcom_pickling" check to command "airflow config lint"
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
… unsupported config check to command "airflow config lint" (apache#45214) * style(cli): add comments comments as deliminator * feat(cli): add removed "core.task_runner" and "core.enable_xcom_pickling" check to command "airflow config lint"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Config
core.task_runner
andcore.enable_xcom_pickling
are removed and will no longer exist in airflow 3.0What
Add lint rules to check these 2 configs
Closes: #45213
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.