Add triggerer info and extra links section to task instance details tab. #46074

tirkarthi · 2025-01-26T16:06:07Z

Add triggerer info on deferred state and extra links section to task instance details like legacy UI .

eladkal · 2025-01-26T16:07:23Z

Can you verify extra link works also for mapped tasks? We have #43757 open for the old ui

tirkarthi · 2025-01-26T16:11:43Z

The API endpoint to fetch extra links doesn't accept map_index so I guess it's not yet supported and should probably be hidden for mapped tasks until implemented like legacy UI.

shubhamraj-git · 2025-01-27T07:34:03Z

@tirkarthi Can you build using #46107 and check your changes for mapped tasks ones? This should fix it.

tirkarthi · 2025-01-29T02:35:37Z

Thanks @shubhamraj-git , I had a similar patch locally and I think the PR should work. I will wait for the changes to be merged to rebase here or take the frontend changes in a new PR after the PR.

bbovenzi

Nice!

I agree, let's add a check for mapIndex for now with a TODO comment to remind us to add in support for mapped tasks soon

airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx

pierrejeambrun · 2025-01-30T14:04:01Z

Is that working locally in breeze ? Are you using another executor because Task SDK does not support extra links so I expect errors there.

shubhamraj-git · 2025-01-30T14:13:42Z

Is that working locally in breeze ? Are you using another executor because Task SDK does not support extra links so I expect errors there.

@pierrejeambrun Yaa possible, I think --executor CeleryExecutor will work.

tirkarthi · 2025-02-01T12:16:33Z

@pierrejeambrun I am using a virtual environment to pull from git and do uv pip install . with airflow scheduler and airflow dag-processor in different shells. I am using extra links as per the docs and using it on BashOperator from from airflow.providers.standard.operators.bash import BashOperator . So I guess I am not using the task sdk here.

https://airflow.apache.org/docs/apache-airflow/stable/howto/define-extra-link.html

potiuk · 2025-02-01T12:26:40Z

@pierrejeambrun I am using a virtual environment to pull from git and do uv pip install . with airflow scheduler and airflow dag-processor in different shells. I am using extra links as per the docs and using it on BashOperator from from airflow.providers.standard.operators.bash import BashOperator . So I guess I am not using the task sdk here.

https://airflow.apache.org/docs/apache-airflow/stable/howto/define-extra-link.html

See https://github.com/apache/airflow/blob/main/contributing-docs/07_local_virtualenv.rst - when we explain how to work with the new virtualenv model where we have mutliple packages: uv sync --all-extras and uv sync --extra celery are your friends as they are using the uv workspace feature which installs all internal airflow packages as needed and all necessary dependencies for the provider extras you specify.

pierrejeambrun

Nice, a few suggestions.

airflow/ui/src/pages/TaskInstance/Details.tsx

airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx

airflow/ui/src/pages/TaskInstance/Details.tsx

airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx

eladkal · 2025-02-04T11:41:30Z

Are we happy with having it in the details tab?
I have to say, I click on the details tab rarely (for the info that we are having there).
On the other hand, I really need the extra link when I view failure logs.

I am not UX expert but I think we need better place for the extra links than the details tab.

tirkarthi · 2025-02-04T11:57:28Z

In Airflow 2 usually clicking on the task instance in grid leads to the task instance details tab. In Airflow 3 logs are made as the default tab. I am fine with moving extra links there if okay.

eladkal · 2025-02-04T12:03:50Z

In Airflow 2 usually clicking on the task instance in grid leads to the task instance details tab. In Airflow 3 logs are made as the default tab. I am fine with moving extra links there if okay.

Getting to the extra links in 2.10 is very inconvenient to my taste.
I would rather the links to be folded/expanded above the logs/events/xcom tabs, but I leave this choice to the UX experts :)

ashb · 2025-02-05T16:10:16Z

airflow/ui/src/pages/Run/Details.tsx

@@ -118,7 +118,7 @@ export const Details = () => {
            </Table.Row>
            {dagRun.external_trigger ? (
              <Table.Row>
-                <Table.Cell>Externally Trigger Source</Table.Cell>
+                <Table.Cell>External Trigger Source</Table.Cell>


@pierrejeambrun @bbovenzi We should nix this "external" word here, as some of the values are "timetable", or "asset" which aren't external.

Do we always want to show dagRun.triggered_by then? instead of only on external triggers?

While we decide on that we can maybe just remove the External word from here as this is misleading:
#46559

…ab. (apache#46074) * Add triggerer info and extra links section to task instance details tab. * Change button variant from default solid to surface to make it lighter. * Add map_index support. * PR comments refactor. * Add section name for task instance details.

tirkarthi requested review from bbovenzi, pierrejeambrun, ryanahamilton and jscheffl as code owners January 26, 2025 16:06

boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 26, 2025

bbovenzi reviewed Jan 29, 2025

View reviewed changes

airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx Outdated Show resolved Hide resolved

tirkarthi force-pushed the ti-triggerer-extra-links branch from 9fe2b33 to b826122 Compare January 30, 2025 03:13

tirkarthi mentioned this pull request Feb 3, 2025

Add map_index parameter to extra links API #46107

Merged

pierrejeambrun reviewed Feb 4, 2025

View reviewed changes

tirkarthi force-pushed the ti-triggerer-extra-links branch from b826122 to 68f5fce Compare February 4, 2025 11:58

tirkarthi added 5 commits February 5, 2025 16:53

Add triggerer info and extra links section to task instance details tab.

e6cf232

Change button variant from default solid to surface to make it lighter.

d0a57eb

Add map_index support.

f86c136

PR comments refactor.

eee3a8d

Add section name for task instance details.

3646bf3

tirkarthi force-pushed the ti-triggerer-extra-links branch from 68f5fce to 3646bf3 Compare February 5, 2025 11:38

pierrejeambrun approved these changes Feb 5, 2025

View reviewed changes

pierrejeambrun merged commit 452f307 into apache:main Feb 5, 2025
35 checks passed

ashb reviewed Feb 5, 2025

View reviewed changes

pierrejeambrun mentioned this pull request Feb 7, 2025

AIP-38 Reword Trigger Section for Runs #46559

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add triggerer info and extra links section to task instance details tab. #46074

Add triggerer info and extra links section to task instance details tab. #46074

tirkarthi commented Jan 26, 2025 •

edited

Loading

eladkal commented Jan 26, 2025 •

edited

Loading

tirkarthi commented Jan 26, 2025

shubhamraj-git commented Jan 27, 2025

tirkarthi commented Jan 29, 2025

bbovenzi left a comment

pierrejeambrun commented Jan 30, 2025

shubhamraj-git commented Jan 30, 2025

tirkarthi commented Feb 1, 2025

potiuk commented Feb 1, 2025

pierrejeambrun left a comment

eladkal commented Feb 4, 2025

tirkarthi commented Feb 4, 2025

eladkal commented Feb 4, 2025 •

edited

Loading

ashb Feb 5, 2025

bbovenzi Feb 5, 2025

pierrejeambrun Feb 7, 2025 •

edited

Loading

Add triggerer info and extra links section to task instance details tab. #46074

Add triggerer info and extra links section to task instance details tab. #46074

Conversation

tirkarthi commented Jan 26, 2025 • edited Loading

eladkal commented Jan 26, 2025 • edited Loading

tirkarthi commented Jan 26, 2025

shubhamraj-git commented Jan 27, 2025

tirkarthi commented Jan 29, 2025

bbovenzi left a comment

Choose a reason for hiding this comment

pierrejeambrun commented Jan 30, 2025

shubhamraj-git commented Jan 30, 2025

tirkarthi commented Feb 1, 2025

potiuk commented Feb 1, 2025

pierrejeambrun left a comment

Choose a reason for hiding this comment

eladkal commented Feb 4, 2025

tirkarthi commented Feb 4, 2025

eladkal commented Feb 4, 2025 • edited Loading

ashb Feb 5, 2025

Choose a reason for hiding this comment

bbovenzi Feb 5, 2025

Choose a reason for hiding this comment

pierrejeambrun Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

tirkarthi commented Jan 26, 2025 •

edited

Loading

eladkal commented Jan 26, 2025 •

edited

Loading

eladkal commented Feb 4, 2025 •

edited

Loading

pierrejeambrun Feb 7, 2025 •

edited

Loading