Skip to content

Adding type ignore to sql hook #46163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 1 commit into from
Jan 28, 2025
Merged

Adding type ignore to sql hook #46163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def placeholder(self) -> str:
@property
def insert_statement_format(self) -> str:
"""Return the insert statement format."""
if not self._insert_statement_format:
if self._insert_statement_format is None:
self._insert_statement_format = self.connection_extra.get(
"insert_statement_format", "INSERT INTO {} {} VALUES ({})"
)
Expand All @@ -216,7 +216,7 @@ def insert_statement_format(self) -> str:
@property
def replace_statement_format(self) -> str:
"""Return the replacement statement format."""
if not self._replace_statement_format:
if self._replace_statement_format is None:
self._replace_statement_format = self.connection_extra.get(
"replace_statement_format", "REPLACE INTO {} {} VALUES ({})"
)
Expand All @@ -225,14 +225,14 @@ def replace_statement_format(self) -> str:
@property
def escape_word_format(self) -> str:
"""Return the escape word format."""
if not self._escape_word_format:
if self._escape_word_format is None:
self._escape_word_format = self.connection_extra.get("escape_word_format", '"{}"')
return self._escape_word_format

@property
def escape_column_names(self) -> bool:
"""Return the escape column names flag."""
if not self._escape_column_names:
if self._escape_column_names is None:
self._escape_column_names = self.connection_extra.get("escape_column_names", False)
return self._escape_column_names

Expand Down