Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StrictHostKeyChecking option to GitDagBundle #46241

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

ephraimbuddy
Copy link
Contributor

This adds an option to enable or disable StrictHostKeyChecking in GitDagBundle. Host key is not checked by default. You have to enable host key checking in the connection extra.

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should fast follow to support passing the host key too.

tests/dag_processing/test_dag_bundles.py Outdated Show resolved Hide resolved
This adds an option to enable or disable StrictHostKeyChecking in
GitDagBundle. Host key is not checked by default. You have to enable
host key checking in the connection extra.
@ephraimbuddy ephraimbuddy force-pushed the add-strict-host-checking branch from 4eeece3 to 564d097 Compare January 30, 2025 08:41
@ephraimbuddy ephraimbuddy merged commit 38b8f78 into apache:main Jan 30, 2025
45 checks passed
@ephraimbuddy ephraimbuddy deleted the add-strict-host-checking branch January 30, 2025 12:34
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
* Add StrictHostKeyChecking option to GitDagBundle

This adds an option to enable or disable StrictHostKeyChecking in
GitDagBundle. Host key is not checked by default. You have to enable
host key checking in the connection extra.

* fixup! Add StrictHostKeyChecking option to GitDagBundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants