Fix pre-commit to re-generate on dependency changes #46259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
approved these changes
Jan 29, 2025
|
Ah NICE.... I missed that one @jscheffl 🤦 |
|
Amazing idea! caplog has more cons than its pros. I think it is one of the most unstable test types. |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Jan 30, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I raised #46216 and I realized that @potiuk added #46220 to fix behind... realized that my local pre-commti did not re-generate files.
This is due to providers move and the fact that provider dependencies are now in pyproject.toml and not in the YAML anymore.
This PR adjusts the pre-commit pattern to ensure files are re-generated if dependencies change.