Add evaluation extra to google-cloud-aiplatform #46270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
|
More explanation: The difference between metadata of 1.78.0 vs. 1.79.0 
We've been installing both extras (pandas, tqdm) by other means before - but we should have been using But no-one else uses scikit learn, so when they added it in 1.79, we have not installed it because we did not have the extra. |
|
That works - no failures in static checks - other errors fxed in upcoming PRs. |
The scikit-learn is an optional dependency of the library from google and apparently we are using the `evaluation` optional feature of it. Adding the extra should make google provider depends on scikit-learn. Closes: apache#46258
potiuk
force-pushed
the
fix-scikit-learn
branch
from
6f59cc6 to
2ed07b4
Compare
amoghrajesh
approved these changes
Jan 30, 2025
|
Error: Attempted a fix: #46276 |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
The scikit-learn is an optional dependency of the library from google and apparently we are using the `evaluation` optional feature of it. Adding the extra should make google provider depends on scikit-learn. Closes: apache#46258 Co-authored-by: Amogh Desai <[email protected]>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Jan 30, 2025
The scikit-learn is an optional dependency of the library from google and apparently we are using the `evaluation` optional feature of it. Adding the extra should make google provider depends on scikit-learn. Closes: apache#46258 Co-authored-by: Amogh Desai <[email protected]>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
The scikit-learn is an optional dependency of the library from google and apparently we are using the `evaluation` optional feature of it. Adding the extra should make google provider depends on scikit-learn. Closes: apache#46258 Co-authored-by: Amogh Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scikit-learn is an optional dependency of the library from google and apparently we are using the
evaluationoptional feature of it. Adding the extra should make google provider depends on scikit-learn.Closes: #46258
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.