Fixed generated SQL MSSQL dialect when all columns are also primary keys - #46380
Merged
Merged
Conversation
…nerated replace sql statement for MSSQL
Contributor
|
Static checks are failing https://github.com/apache/airflow/actions/runs/13154423653/job/36708789726?pr=46380#step:6:218 |
Contributor
Author
should be fixed now |
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
…eys (apache#46380) * refactor: Fixed case when all columns are part of primary key when generated replace sql statement for MSSQL * refactor: Reformatted TestMsSqlDialect * refactor: Reformatted create_db_api_hook --------- Co-authored-by: David Blain <david.blain@infrabel.be>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…eys (apache#46380) * refactor: Fixed case when all columns are part of primary key when generated replace sql statement for MSSQL * refactor: Reformatted TestMsSqlDialect * refactor: Reformatted create_db_api_hook --------- Co-authored-by: David Blain <david.blain@infrabel.be>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…eys (apache#46380) * refactor: Fixed case when all columns are part of primary key when generated replace sql statement for MSSQL * refactor: Reformatted TestMsSqlDialect * refactor: Reformatted create_db_api_hook --------- Co-authored-by: David Blain <david.blain@infrabel.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the case when all columns are also primary keys when generating the replace SQL statement for MS SQL.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.