Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Legacy configuration not removed or updated #46544

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jason810496
Copy link
Contributor

closes: #46517

The inversed_deprecated_options logic in config_command.py causes config lint to retrieve the new section-option pair from the old section-option pair. Adding the lookup_from_deprecated_options argument can resolve the error.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jason810496
Copy link
Contributor Author

Followup:

Should we add a pre-commit check to ensure the default configuration doesn’t raise issues with airflow config lint?
cc @Lee-W

@Lee-W
Copy link
Member

Lee-W commented Feb 7, 2025

Followup:

Should we add a pre-commit check to ensure the default configuration doesn’t raise issues with airflow config lint? cc @Lee-W

sounds like a great idea!

@jason810496 jason810496 force-pushed the fix/legacy-configuration-not-removed-or-updated branch from 96b4fd2 to ed8c6bd Compare February 7, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy configuration not removed or updated
2 participants