-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task details overview page with duration chart. #46631
Conversation
1d307f6
to
6a5d7b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the factorization should be part of this PR. I'm not super confident merging code duplication especially when this is most of the PR content.
Other improvements / tweaks can be done later.
6a5d7b9
to
ee9141a
Compare
@pierrejeambrun I have refactored them to a common component |
06ef97d
to
cd75d76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit on variable names.
…ithout filters and pagination applied.
cd75d76
to
42d3343
Compare
The chart currently uses |
Yeah, I'm happy to merge now and figure out logical date later. |
Thanks @bbovenzi and @pierrejeambrun . |
* Add task details overview page with duration chart. * Use the elements count instead total_entries which is a total count without filters and pagination applied. * Refactor duration chart to a single component. * Handle instances that got queued and marked with no start_date. * Enforce types. * Fix variable name. * Fix rebase.
Similar to #46504 . Add widget to plot failed task instances within given logical date selected and on click goes to task instances page with state filter applied. Similar to Airflow 2 and other PR the charts are almost the same except for small differences like queued_dttm/queued_when for queued calculation and can be refactored in a later PR to avoid code duplication. Change sort to order by
logical_date
since the chart is constructed withlogical_date
along x-axis. Handle skipped tasks wherequeued_when
is null and resort to queued duration as zero.