AIP-81 Include CLI Token Expiration Time API Configuration and Integrate New Config in SimpleAuthManager #46839
Conversation
bugraoz93
added
area:auth
AIP-81
bugraoz93
force-pushed
the
feat/46837/expiration-config-cli
branch
from
35f0584 to
320daae
Compare
That is exactly my intention :) Thanks for the review! Fixed the openapi specs. Surprised it got away from my local pre-commit run before the commit. |
For sure, I am going to add them. Sorry for double-checking! I am going to work on the changes needed in FAB next for this integration. I might again need your review there :) |
For sure! Happy to review :) Feel free to add me as reviewer/tag me |
bugraoz93
force-pushed
the
feat/46837/expiration-config-cli
branch
from
320daae to
9f69120
Compare
…ce to decide and auth with simple auth manager to enable further development
Thanks a lot! I will do that :) I added unit tests and moved some parts to |
bugraoz93
force-pushed
the
feat/46837/expiration-config-cli
branch
from
9f69120 to
758ac9b
Compare
|
Sorry I did not add comments as part of one review, they arrived in my mind after my first review :) |
All welcome! Thanks! I'm going to check in a moment :) |
…and route test logic and include tests
|
I addressed them all. Whenever you have time :) |
airflow/auth/managers/simple/services/simple_auth_manager_login.py
Outdated
Show resolved
Hide resolved
Thanks for your time! :) |
…ate New Config in SimpleAuthManager (apache#46839)
closes: #46837
I also included the token generation in SimpleAuthManager to enable further development.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.