Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dag version selector for source code. #46885

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

tirkarthi
Copy link
Contributor

With dag version only latest code is displayed. Add dropdown selector whose version values gets filled from API and on select append version query parameter to URL to retrieve source code for the selected dag version. By default latest version is displayed. This can be used to display the relevant version of code for a given run and task instance in the respective tab later.

image

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Feb 19, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@pierrejeambrun
Copy link
Member

cc: @jedcunningham @bbovenzi

At some point we talked about linking the older code version to the version_url (the github link for instance), do you have something else in mind or does this make sense in it's current state ?

@bbovenzi
Copy link
Contributor

cc: @jedcunningham @bbovenzi

At some point we talked about linking the older code version to the version_url (the github link for instance), do you have something else in mind or does this make sense in it's current state ?

I don't see a problem with both showing the code and having a link to version_url

@bbovenzi bbovenzi merged commit bb56052 into apache:main Feb 19, 2025
36 checks passed
ntr pushed a commit to ntr/airflow that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants