Fix run/task table links #46901
Merged
Fix run/task table links #46901
+11
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
pierrejeambrun
approved these changes
Feb 19, 2025
|
Might be a bit weird to have a run link to a TI. We can always adjust later. |
Yes, but this is on the Task details (across all runs) page. I think in that context it works. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the global dag run and task instance tables. I accidentally broke the idea that each row should only have one link to its relevant element. Since we adjust which columns to show depending on the page you're on. Sometimes we didn't even have the link to a task instance.
Now, we only ever link to the dag run or task instance. And even if the task_id column is missing, we fallback on linking to the task instance from the run id column
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.