-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 Add multisort to dags list request #46383 #47440
base: main
Are you sure you want to change the base?
AIP-84 Add multisort to dags list request #46383 #47440
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the pull request 🎉
I think we need:
- To allow multi sorting on the
get dags
endpoint to solve the related issue. - Add tests for the
get dags
endpoint with multiple sort in the query and assert that it is doing what we expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we need some tests too.
Don't hesitate to |
Yes, currently working on that, will update the PR once it is done. |
I thought to do it after writing test cases. |
Hi @pierrejeambrun , I have added few tests, COuld you please review it and let me know if any additional things to be required. |
…bug-add-multisort-to-dags-list-request-apache#46383
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Looking good overall. One couple of comments only.
CI need fixing (tests, static check etc.), can you also rebase the branch solve conflicts.
…bug-add-multisort-to-dags-list-request-apache#46383
@pierrejeambrun could you please review the PR, If any changes needs to be done, I'll address those. |
Description:
backend part of: #46383
Test cases screenshot