-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GitDagBundle
to providers
#47636
Conversation
c33cd18
to
c123c9b
Compare
23fa0ba
to
6bc6572
Compare
I dismissed the alerts from CodeQL as false positive. For the compat tests - git provider should only be for airflow 3 so you should also add git to the list of excluded providers in src/airflow_breeze/global_constants.py (PROVIDERS_COMPATIBILITY_TESTS_MATRIX) |
Thanks! Almost got stuck at that! @dstandish is also fixing false positive at #47685 |
0af257c
to
927c584
Compare
Looks good in my view. Shall we add some config (don't know where) to ensure this provider is installed per default in Airflow Docker images released? |
927c584
to
d29890f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this provider to be listed in the PRE_INSTALLED_PROVIDERS ?
Strong YES. I assume very many people will use this as git sync is used often as standard in helm chart as well... (which contradicts a bit with #47927 :-D) |
Hmm. I think it should be rather in https://github.com/apache/airflow/blob/main/prod_image_installed_providers.txt |
Ups, okay, sorry, mis-conception on my side. Strong YES so that the install is in the Docker, don't need to be in the PIP Distribution directly. |
d29890f
to
df69535
Compare
df69535
to
fb44fda
Compare
I think you need to rebase now after airflow-core move and run this:
That should regenerate all the "build" documentation in provider package using the latest templates. |
fb44fda
to
595c3c2
Compare
fcf91e9
to
92eed23
Compare
Any idea why the github provider is failing? https://github.com/apache/airflow/actions/runs/14037483223/job/39299511614?pr=47636#step:11:3507 cc @potiuk |
007040d
to
bb75e96
Compare
One small thing to fix. |
bb75e96
to
abef0e9
Compare
This commit moves GitDagBundle into the providers package. As part of the move, a new `GIT` provider is created and like `operators`, `transfers` etc, we now have `bundles` package. The bundle package is where the `GitDagBundles` lives.
Co-authored-by: Elad Kalif <[email protected]>
5045074
to
a617218
Compare
* Move `GitDagBundle` to providers This commit moves GitDagBundle into the providers package. As part of the move, a new `GIT` provider is created and like `operators`, `transfers` etc, we now have `bundles` package. The bundle package is where the `GitDagBundles` lives. * fixup! Move `GitDagBundle` to providers * Update documentation * Fix static checks * add git to compatibility tests matrix * Update doctree * Update with recent changes * Fix doc, update version and add provider to prod image preinstalled providers * fixup! Fix doc, update version and add provider to prod image preinstalled providers * Fix doc * update breeze command hash * Fix incompatible providers regex removal syntax * Remove providers mistakenly added in pyproject.toml * Update providers/git/pyproject.toml
This commit moves GitDagBundle into the providers package. As part of the move, a new
GIT
provider is created and likeoperators
,transfers
etc, we now havebundles
package. The bundle package is where theGitDagBundles
lives.