Move generate_jwt_token to test_common.test_utils
#47712
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
jason810496
force-pushed
the
refactor/make-generate-jwt-token-as-common-module
branch
from
518b485 to
e2d468d
Compare
jason810496
added
area:CI
jason810496
force-pushed
the
refactor/make-generate-jwt-token-as-common-module
branch
from
e2d468d to
b5e2169
Compare
jason810496
requested review from
potiuk,
ashb and
gopidesupavan
as code owners
jason810496
force-pushed
the
refactor/make-generate-jwt-token-as-common-module
branch
2 times, most recently
from
3c72861 to
b022a62
Compare
jason810496
force-pushed
the
refactor/make-generate-jwt-token-as-common-module
branch
from
b022a62 to
ca65747
Compare
| :return: The JWT token | ||
| """ | ||
| Retry.DEFAULT_BACKOFF_MAX = 32 | ||
| retry = Retry(total=10, backoff_factor=1) |
There was a problem hiding this comment.
It would be good to add some status_forcelist or provide a config? the default status_forcelist is None
There was a problem hiding this comment.
I just added 429 and common 5xx server side error as status_forcelist, thanks for the catch !
jason810496
force-pushed
the
refactor/make-generate-jwt-token-as-common-module
branch
from
35d6fbd to
58cd84d
Compare
jason810496
force-pushed
the
refactor/make-generate-jwt-token-as-common-module
branch
from
58cd84d to
37e712d
Compare
jason810496
added
the
full tests needed
|
#48498 is now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related slack discussion: https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1741769075107729
Why
Since AIP-84 | Add Auth for Dags #47433 introduces
get_jwt_tokenwith the new login flow for testing. To ensure consistency, this test utility should have a single source acrossclients/python/test_python_client.py,docker_tests, andkubernetes_tests.How
generate_jwt_tokenandRefreshJwtAdapteras utility functions.get_jwt_tokentogenerate_jwt_token, as suggested by @ashb.