-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensures DatabricksWorkflowOperator updates ACL (if available) when resetting a job. #47827
base: main
Are you sure you want to change the base?
Ensures DatabricksWorkflowOperator updates ACL (if available) when resetting a job. #47827
Conversation
c13647c
to
ce4d7c4
Compare
:-) |
@hardeybisey , can we add a test? |
Sure, I will add the test and tag you once it's done. |
fd92a88
to
9b387d1
Compare
9b387d1
to
1172e6c
Compare
@rawwar I have added test to the PR. |
self.job_name, | ||
access_control_list, | ||
) | ||
self._hook.update_job_permission( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is always expected to happen while resetting the job when the ACL is available, I suggest we move this call in the hook's reset_job method. Like that any further usage of the reset_job method will ensure that updating ACL automatically happens in case someone forgets to make this isolated call.
As I am checking, I see we have a similar occurrence in the Create Jobs operator at https://github.com/apache/airflow/blob/main/providers/databricks/src/airflow/providers/databricks/operators/databricks.py#L402. We could refactor that once we move this call to the reset_job method.
116bcfe
to
5695ffe
Compare
24f9b1c
to
48b115e
Compare
48b115e
to
7512fe3
Compare
...
closes: #45738
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.