Handle missing container_statuses in pod_manager.get_container_status #47936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForeverWintr
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
@mrk-andreev you are the author of PR I linked, could you give my change a review? |
ForeverWintr
changed the title
|
@ForeverWintr, thank you for fixing it! Looks good from my side. |
ForeverWintr
force-pushed
the
fix-get-container-status
branch
2 times, most recently
from
a72aa50 to
3ac4a42
Compare
|
@jedcunningham or @hussein-awala, could one of you take a look at this? |
eladkal
force-pushed
the
fix-get-container-status
branch
from
3ac4a42 to
cf5a408
Compare
ForeverWintr
force-pushed
the
fix-get-container-status
branch
4 times, most recently
from
9377ceb to
d77227e
Compare
ForeverWintr
force-pushed
the
fix-get-container-status
branch
from
d77227e to
b9773b1
Compare
jscheffl
approved these changes
Mar 26, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
…apache#47936) * Add failing example test * Handle cases where container_statuses is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there is a small bug in the cncf/kubernetes provider. Previously
get_container_statusinpod_manager.pywould handle cases wherepod.status.container_statusesisNone, but after #43853 it does not. This PR adds a test illustrating the issue, and fixes it.