Do not call runtime-checks api from the task sdk anymore #48125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
approved these changes
Mar 24, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
prabhusneha
force-pushed
the
remove_runtime_checks_api
branch
2 times, most recently
from
be0246d to
326f598
Compare
prabhusneha
requested review from
vincbeck,
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
XD-DENG
as code owners
prabhusneha
force-pushed
the
remove_runtime_checks_api
branch
from
326f598 to
f8ed470
Compare
amoghrajesh
approved these changes
Mar 25, 2025
|
I'd like to check how Cadwyn handles this versioning before we merge please |
|
Good call! How do we test that since its an internal api? |
…versions Although right now we don't have any API clients calling the previous version since we aren't released yet and could have simply deleted the endpoint outright, this is a good opportunity to use this as a practice run for API versioning
|
@kaxil @amoghrajesh @pierrejeambrun Anyone else interested in the API versioning: please take a look at the second commit in this PR: 97d16b9 |
kaxil
approved these changes
Mar 26, 2025
I am curious to see how things change, if an existing datamodel or its field changes and stuff. Nothing new for them -- but curious how it would look :) |
ashb
reviewed
Mar 26, 2025
ashb
approved these changes
Mar 26, 2025
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
We'd already removed any meaningfull checks in this endpoint in a previous PR Although right now we don't have any API clients calling the previous version since we aren't released yet and could have simply deleted the endpoint outright, this is a good opportunity to use this as a practice run for API versioning --------- Co-authored-by: Sneha Prabhu <[email protected]> Co-authored-by: Ash Berlin-Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #47988
This PR removes the
/task_instances/{uuid}/runtime-checksAPI and as its consumption.