Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking if sources are mounted in breeze image #48499

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 28, 2025

The check for mounted sources in the breeze image checked for presence of "airflow" folder, but this folder is now mounted via init.py and version check so we have to check for presence of another file (main.py).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

The check for mounted sources in the breeze image checked for presence
of "airflow" folder, but this folder is now mounted via  __init__.py
and version check so we have to check for presence of another file
(__main__.py).
@potiuk potiuk force-pushed the fix-checking-for-mounted-sources branch from a0466f3 to c20a8fa Compare March 28, 2025 13:52
Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you so much for fixing this together with #48495 👏🏽 🙇🏽‍♂️

@potiuk potiuk merged commit cf7acc0 into apache:main Mar 28, 2025
84 checks passed
@potiuk potiuk deleted the fix-checking-for-mounted-sources branch March 28, 2025 14:20
pankajkoti pushed a commit to astronomer/airflow that referenced this pull request Mar 28, 2025
The check for mounted sources in the breeze image checked for presence
of "airflow" folder, but this folder is now mounted via  __init__.py
and version check so we have to check for presence of another file
(__main__.py).
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Apr 2, 2025
The check for mounted sources in the breeze image checked for presence
of "airflow" folder, but this folder is now mounted via  __init__.py
and version check so we have to check for presence of another file
(__main__.py).
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
The check for mounted sources in the breeze image checked for presence
of "airflow" folder, but this folder is now mounted via  __init__.py
and version check so we have to check for presence of another file
(__main__.py).
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
The check for mounted sources in the breeze image checked for presence
of "airflow" folder, but this folder is now mounted via  __init__.py
and version check so we have to check for presence of another file
(__main__.py).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants