Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 - Add user id when updating notes in dag_run #48524

Merged
merged 4 commits into from
Mar 31, 2025

Conversation

rawwar
Copy link
Contributor

@rawwar rawwar commented Mar 29, 2025

related to #43534

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Mar 29, 2025
@rawwar rawwar requested a review from Lee-W March 29, 2025 07:19
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Left some nits for the tests part.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks. (once Jason comments are resolved)

@rawwar
Copy link
Contributor Author

rawwar commented Mar 31, 2025

Looks good to me thanks. (once Jason comments are resolved)

I just pushed a minute ago

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit then we can merge.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Let wait for CI finish.

@jason810496 jason810496 merged commit 57daf59 into apache:main Mar 31, 2025
91 checks passed
@rawwar rawwar deleted the kalyan/AIP-84/dag_run/add_user_id branch March 31, 2025 11:54
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Apr 2, 2025
* add user id to note's

* refactor dag run note check

* refactor
amolsr pushed a commit to amolsr/airflow that referenced this pull request Apr 2, 2025
* add user id to note's

* refactor dag run note check

* refactor
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* add user id to note's

* refactor dag run note check

* refactor
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
* add user id to note's

* refactor dag run note check

* refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants