Clean up import error records during DB migration - #51472
Merged
ephraimbuddy merged 2 commits intoJun 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a utility function to clean up old import errors from the ParseImportError table (specifically, entries lacking a bundle_name) after the DB migration, addressing a bug where such errors would not be cleared by existing logic.
- Added delete_import_errors function in db.py
- Updated the upgradedb workflow to invoke the cleanup function
ephraimbuddy
force-pushed
the
delete-import-errors-after-upgrade
branch
2 times, most recently
from
June 6, 2025 18:25
68a035d to
5b8b026
Compare
jedcunningham
approved these changes
Jun 6, 2025
This PR adds an SQL to clean up import errors during add bundle migration The bug we found was that import errors with null bundle_name field doesn't get cleared after migration. The processor manager's `clear_orphaned_import_errors` method filters by bundle_name and that makes the import errors with null bundle_name not to be included in the method's result
ephraimbuddy
force-pushed
the
delete-import-errors-after-upgrade
branch
from
June 7, 2025 07:00
5b8b026 to
0fd1ce8
Compare
eladkal
approved these changes
Jun 7, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Clean up import error records during DB migration This PR adds an SQL to clean up import errors during add bundle migration The bug we found was that import errors with null bundle_name field doesn't get cleared after migration. The processor manager's `clear_orphaned_import_errors` method filters by bundle_name and that makes the import errors with null bundle_name not to be included in the method's result * fixup! Clean up import error records during DB migration
kevinhongzl
pushed a commit
to kevinhongzl/airflow
that referenced
this pull request
Jun 7, 2025
* Clean up import error records during DB migration This PR adds an SQL to clean up import errors during add bundle migration The bug we found was that import errors with null bundle_name field doesn't get cleared after migration. The processor manager's `clear_orphaned_import_errors` method filters by bundle_name and that makes the import errors with null bundle_name not to be included in the method's result * fixup! Clean up import error records during DB migration
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 19, 2025
* Clean up import error records during DB migration This PR adds an SQL to clean up import errors during add bundle migration The bug we found was that import errors with null bundle_name field doesn't get cleared after migration. The processor manager's `clear_orphaned_import_errors` method filters by bundle_name and that makes the import errors with null bundle_name not to be included in the method's result * fixup! Clean up import error records during DB migration (cherry picked from commit 7ed78dc)
potiuk
pushed a commit
that referenced
this pull request
Jun 21, 2025
* Clean up import error records during DB migration (#51472) * Clean up import error records during DB migration This PR adds an SQL to clean up import errors during add bundle migration The bug we found was that import errors with null bundle_name field doesn't get cleared after migration. The processor manager's `clear_orphaned_import_errors` method filters by bundle_name and that makes the import errors with null bundle_name not to be included in the method's result * fixup! Clean up import error records during DB migration (cherry picked from commit 7ed78dc) * Move import error deletion migration to separate file (#51565) (cherry picked from commit 95a1e77)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an SQL to clean up import errors during add bundle migration
The bug we found was that import errors with null bundle_name field doesn't get cleared after migration. The processor manager's
clear_orphaned_import_errorsmethod filters by bundle_name and that makes the import errors with null bundle_name not to be included in the method's resultTested this manually