Skip to content

Fix the "Copy" button for the run config on DAG run details #58433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
molcay wants to merge 1 commit into from
+10 −2
Closed

Fix the "Copy" button for the run config on DAG run details #58433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions airflow/www/static/js/components/RenderedJsonField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import React from "react";
import React, { useEffect } from "react";

import ReactJson, { ReactJsonViewProps } from "react-json-view";

Expand All @@ -39,9 +39,17 @@ interface Props extends FlexProps {

const RenderedJsonField = ({ content, jsonProps, ...rest }: Props) => {
const [isJson, contentJson, contentFormatted] = jsonParse(content);
const { onCopy, hasCopied } = useClipboard(contentFormatted);
const { onCopy, hasCopied, setValue } = useClipboard(contentFormatted);
const theme = useTheme();

// Current version of the "@chakra-ui/hooks v2.1.2" have a problem with multiple different run configs.
// The following code piece derived from this issue: https://github.com/chakra-ui/chakra-ui/issues/6759
useEffect(() => {
if (contentFormatted) {
setValue(contentFormatted);
}
}, [contentFormatted, setValue]);

return isJson ? (
<Flex {...rest} p={2}>
<ReactJson
Expand Down
Loading