Skip to content

Change google sheets operator and connected system tests - #66929

Merged
potiuk merged 4 commits into
apache:mainfrom
VladaZakharova:update-sheets-operator
Aug 27, 2026
Merged

potiuk merged 4 commits into
apache:mainfrom
VladaZakharova:update-sheets-operator

Conversation

@Crowiant

@Crowiant Crowiant commented May 14, 2026 •

Copy link
Copy Markdown
Contributor

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Important

🛠️ Maintainer triage note for @Crowiant · by @potiuk · 2026-07-08 15:51 UTC

Some review feedback from @potiuk is waiting on you (4 unresolved threads):

The ball is in your court — you've been assigned to this PR. Reply or push a fix in each thread, then mark them resolved. See the Pull Request quality criteria.

Automated triage — may be imperfect; a maintainer takes the next look.

@Crowiant
Crowiant requested a review from shahar1 as a code owner May 14, 2026 10:05
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels May 14, 2026
@choo121600 choo121600 added the ready for maintainer review Set after triaging when all criteria pass. label May 15, 2026

@SameerMesiah97 SameerMesiah97 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments.

Also, for future reference I would write a more comprehensive PR description (or at the very least a more clear title) to more explicity communicate the intention behind these changes.

Comment thread providers/google/src/airflow/providers/google/suite/operators/sheets.py Outdated
Comment thread providers/google/src/airflow/providers/google/suite/hooks/drive.py Outdated
Comment thread providers/google/src/airflow/providers/google/suite/operators/sheets.py Outdated
Comment thread providers/google/tests/system/google/cloud/gcs/example_gcs_to_sheets.py Outdated
Comment thread providers/google/tests/system/google/cloud/gcs/example_sheets.py Outdated
Comment thread providers/google/tests/system/google/cloud/gcs/example_sheets_to_gcs.py Outdated
Comment thread providers/google/tests/system/google/cloud/sql_to_sheets/example_sql_to_sheets.py Outdated
@Crowiant
Crowiant force-pushed the update-sheets-operator branch 4 times, most recently from 5d4fd22 to 6e782f5 Compare May 22, 2026 19:14
@Crowiant
Crowiant force-pushed the update-sheets-operator branch 2 times, most recently from 8338f02 to 65996e3 Compare May 29, 2026 10:14
Comment thread providers/google/src/airflow/providers/google/suite/operators/sheets.py Outdated
Comment thread providers/google/tests/system/google/cloud/gcs/example_sheets.py Outdated
Comment thread providers/google/tests/system/google/cloud/gcs/example_gcs_to_sheets.py Outdated
@potiuk

potiuk commented Jun 25, 2026

Copy link
Copy Markdown
Member

@Crowiant — I've removed the ready for maintainer review label because the next step here is yours: there are 4 unresolved review thread(s) awaiting your reply. It'll go back into the maintainer queue automatically once you've addressed them — no need to re-add the label by hand. There's no rush.

Automated triage note drafted by an AI-assisted tool — may get things wrong; a real Apache Airflow maintainer takes the next look once they're resolved. (why automated)


Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting

@potiuk potiuk removed the ready for maintainer review Set after triaging when all criteria pass. label Jun 25, 2026
@potiuk

potiuk commented Jul 20, 2026

Copy link
Copy Markdown
Member

@Crowiant — There are 4 unresolved review thread(s) on this PR from @shahar1. Could you either push a fix or reply in each thread explaining why the feedback doesn't apply? Once you believe the feedback is addressed, mark the thread as resolved so the reviewer isn't re-pinged needlessly. Thanks!


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@lubimow-xwf
lubimow-xwf force-pushed the update-sheets-operator branch from 9d92f12 to 18c1103 Compare August 12, 2026 12:43
@VladaZakharova

Copy link
Copy Markdown
Contributor

@potiuk @shahar1 Can you please check again the changes in this PR?

@potiuk
potiuk dismissed shahar1’s stale review August 27, 2026 10:54

All issues solved

@potiuk
potiuk merged commit ecf2842 into apache:main Aug 27, 2026
86 checks passed
imrichardwu pushed a commit to imrichardwu/airflow that referenced this pull request Sep 11, 2026
* Change google sheets operator and connected system tests

* WIP: Fix documentation issues

* Refactor tests to not use render_template_as_native_obj

* Cast XComArg to expected types to satisfy mypy

---------

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Co-authored-by: Marcin Lubimow <lubimow@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants