Add destination_folder_id to GCSToGoogleDriveOperator templated fields and update google drive system tests - #66930
Conversation
1104480 to
b7a2739
Compare
b7a2739 to
44fe181
Compare
|
@Crowiant — Your unresolved review thread(s) from @phanikumv, @shahar1 appear to have been addressed (post-review commits and/or in-thread replies on every thread, with the latest commit pushed after the most recent thread). I've added the @phanikumv, @shahar1 — could you take another look when you have a chance? If you agree the feedback was addressed, please mark the threads as resolved so the queue signal stays accurate. If a thread still needs work, please reply in-line — @Crowiant will follow up. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @choo121600 before posting |
61f1ee7 to
7e67519
Compare
|
@Crowiant — There are 1 unresolved review thread on this PR from @phanikumv. Could you either push a fix or reply in each thread explaining why the feedback doesn't apply? Once you believe the feedback is addressed, mark the thread as resolved so the reviewer isn't re-pinged needlessly. Thanks! Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
|
Hello @shahar1 Can we proceed with this PR if everything is ok? |
shahar1
left a comment
There was a problem hiding this comment.
The comment regarding folder_id is a blocker from my prespective (I want to avoid situations where system tests become fragile and then break).
Also, please update PR title and description.
CC: @VladaZakharova
|
@Crowiant — There are 3 unresolved review thread(s) on this PR from Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
064ffba to
6300248
Compare
|
@Crowiant — I've removed the Automated triage note drafted by an AI-assisted tool — may get things wrong; a real Apache Airflow maintainer takes the next look once they're resolved. (why automated) Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting |
Fix get_media_request to include all drives
66e8e2a to
4dabaa9
Compare
|
hey @shahar1 , I applied the fixes, please have a look again |
…s and update google drive system tests (apache#66930) * Change gdrive system tests * Remove FOLDER_ID variable from example_gcs_to_drive test Fix get_media_request to include all drives * Fix drive test and formatting --------- Co-authored-by: Anton Nitochkin <nitochkin@google.com> Co-authored-by: Marcin Lubimow <lubimow@google.com>
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.Important
🛠️ Maintainer triage note for @Crowiant · by
@potiuk· 2026-07-08 15:51 UTCSome review feedback from
@potiukis waiting on you (2 unresolved threads):The ball is in your court — you've been assigned to this PR. Reply or push a fix in each thread, then mark them resolved. See the Pull Request quality criteria.
Automated triage — may be imperfect; a maintainer takes the next look.