Parse additional Kafka, Redis & SQS options in broker_transport_options - #70228
Merged
Merged
Conversation
stephen-bracken
force-pushed
the
fix-celery-json
branch
10 times, most recently
from
July 23, 2026 09:06
a6b6db4 to
0e89415
Compare
stephen-bracken
marked this pull request as ready for review
July 23, 2026 10:38
stephen-bracken
requested review from
dheerajturaga and
hussein-awala
as code owners
July 23, 2026 10:38
Miretpl
requested changes
Jul 31, 2026
Miretpl
left a comment
Contributor
There was a problem hiding this comment.
Could you update the provider documentation configuration?
stephen-bracken
force-pushed
the
fix-celery-json
branch
2 times, most recently
from
August 1, 2026 18:33
72bf60c to
8538b1f
Compare
Miretpl
requested changes
Aug 11, 2026
stephen-bracken
force-pushed
the
fix-celery-json
branch
7 times, most recently
from
August 13, 2026 16:32
f8c5ace to
1233155
Compare
* remove formatting from `fetch_message_attributes` example * change `AirflowException` to `ValueError` Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
stephen-bracken
force-pushed
the
fix-celery-json
branch
from
August 13, 2026 16:32
1233155 to
0083b4f
Compare
stephen-bracken
force-pushed
the
fix-celery-json
branch
from
August 13, 2026 17:27
0083b4f to
d57b7f7
Compare
stephen-bracken
force-pushed
the
fix-celery-json
branch
from
August 14, 2026 08:03
8b46666 to
b18a520
Compare
Miretpl
requested changes
Aug 15, 2026
Miretpl
left a comment
Contributor
There was a problem hiding this comment.
Small nits and we will be ready to merge. Thanks for taking care of AirflowException here!
Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
Miretpl
approved these changes
Aug 17, 2026
Miretpl
left a comment
Contributor
There was a problem hiding this comment.
Will leave it a day or two open if anyone would like to make review too.
broker_transport_optionsbroker_transport_options
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
…ons` (apache#70228) * parse additional dict options in broker_transport_options * Apply suggestions from code review * remove formatting from `fetch_message_attributes` example * change `AirflowException` to `ValueError` Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com> * update type hinting * add predefined_queues test and config doc * fix mypy and linting * Update exception messages Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com> * fix linting --------- Co-authored-by: Stephen Bracken <email-protected> Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse additional dict options in
broker_transport_optionsThe following options in
broker_transport_optionsare processed as nested dictionaries in the celery config, they should be json parsed in the same way assentinel_kwargswhen creating thedefault_celery.DEFAULT_CELERY_CONFIGKafka:
kafka_admin_configkafka_common_configkafka_consumer_configkafka_producer_configRedis:
sentinel_kwargsSQS:
client-configfetch_message_attributespredefined_exchangespredefined_queuessqs-creation-attributesWas generative AI tooling used to co-author this PR?