Skip to content

Fix Cloud Build operator template preparation - #70794

Closed
abhisek343 wants to merge 1 commit into
apache:mainfrom
abhisek343:agent/fix-cloud-build-operator-init
Closed

abhisek343 wants to merge 1 commit into
apache:mainfrom
abhisek343:agent/fix-cloud-build-operator-init

Conversation

@abhisek343

@abhisek343 abhisek343 commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

CloudBuildCreateBuildOperator stores a second copy of the templated build argument in build_raw during construction. This additional value read requires the operator to remain exempt from template-field constructor validation.

This change removes build_raw and uses a local build_path inside prepare_template() while loading JSON or YAML into self.build. Existing template-loading behavior remains unchanged, while the constructor now only assigns the argument to its corresponding instance field.

The obsolete constructor-validation exemption is removed in the same change.

related: #70296
cc @potiuk — taking CloudBuildCreateBuildOperator from the burn-down list.

Validation

  • Cloud Build operator unit tests: 36 passed
  • Operator constructor validation: passed
  • Ruff formatting and lint checks: passed
  • Git diff whitespace validation: passed

Was generative AI tooling used to co-author this PR?
  • Yes — OpenAI Codex

Generated-by: OpenAI Codex following the guidelines

@boring-cyborg boring-cyborg Bot added area:dev-tools area:providers backport-to-v3-3-test Backport to v3-3-test provider:google Google (including GCP) related issues labels Jul 30, 2026
@boring-cyborg

boring-cyborg Bot commented Jul 30, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@abhisek343
abhisek343 marked this pull request as ready for review July 30, 2026 19:38
@eladkal eladkal removed the backport-to-v3-3-test Backport to v3-3-test label Aug 3, 2026
@abhisek343
abhisek343 force-pushed the agent/fix-cloud-build-operator-init branch from 93c672c to ab6b062 Compare August 19, 2026 10:23
@olayiwola-gbenga

Copy link
Copy Markdown
Contributor

Hi @abhisek343 please look into the failing checks

@shahar1

shahar1 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #70794 (included the first commit which is attributed to this PR's autthor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants