Fix Dataflow sensors losing their XCom value when not deferred - #71086
Merged
shahar1 merged 2 commits intoSep 17, 2026
Merged
Conversation
FrankYang0529
marked this pull request as ready for review
August 4, 2026 14:01
FrankYang0529
force-pushed
the
airflow-dataflow-sensor-return-value
branch
4 times, most recently
from
August 6, 2026 00:29
7a15528 to
79e0ff2
Compare
Contributor
|
Hi @FrankYang0529, Thank you for your change. It is very much appreciated! From my side, it seems a good change. However we want to see the system tests run results before merging a change. Did you run the system tests? Can you share the results of the system tests? |
shahar1
approved these changes
Sep 13, 2026
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
airflow-dataflow-sensor-return-value
branch
2 times, most recently
from
September 14, 2026 13:08
79e0ff2 to
fb97f4b
Compare
Member
Author
@molcay Thanks for the suggestion. I add a xcom assertion to system test and make sure it passes on this branch, but fails on main branch.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
DataflowJobMessagesSensor,DataflowJobAutoScalingEventsSensorandDataflowJobMetricsSensorreturn their payload to XCom when deferred, but drop it in poke mode.deferrabledefaults toFalse, so the default path is the broken one.The payload travels through a chain, and these sensors break it at the last step:
How
super().execute(context)from the three sensors'execute()overrides.DataflowJobMetricsSensor.poke()'s result inPokeReturnValue, the same way Bugfix/return DataflowJobMessagesSensor and DataflowJobAutoScalingEventsSensor result with xcom_value #53115 did for the other two.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.