Skip to content

Report missing Anthropic WIF fields clearly - #71359

Merged
shahar1 merged 2 commits into
apache:mainfrom
yuyua9:fix/anthropic-wif-missing-fields-yuyua9
Sep 18, 2026
Merged

shahar1 merged 2 commits into
apache:mainfrom
yuyua9:fix/anthropic-wif-missing-fields-yuyua9

Conversation

@yuyua9

@yuyua9 yuyua9 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Invalid Anthropic Workload Identity Federation configuration currently raises a raw KeyError when a required field is missing, which makes connection setup failures harder to diagnose.

This PR:

  • Validates the four required workload_identity fields before indexing them.
  • Raises AnthropicError listing missing or empty fields.
  • Adds parameterized regression tests for missing and empty values while preserving optional workspace_id and scope handling.

Validation:

  • uv run --project providers/anthropic --frozen pytest providers/anthropic/tests/unit/anthropic/hooks/test_anthropic.py -xvs — 87 passed.
  • uv run --project providers/anthropic --frozen ruff format providers/anthropic/src/airflow/providers/anthropic/hooks/anthropic.py providers/anthropic/tests/unit/anthropic/hooks/test_anthropic.py
  • uv run --project providers/anthropic --frozen ruff check --fix providers/anthropic/src/airflow/providers/anthropic/hooks/anthropic.py providers/anthropic/tests/unit/anthropic/hooks/test_anthropic.py
  • The Breeze provider test command was not run because Breeze is unavailable in the local environment.
Was generative AI tooling used to co-author this PR?
  • Yes — Codex (GPT-5)

Generated-by: Codex (GPT-5) following the guidelines

@boring-cyborg

boring-cyborg Bot commented Aug 10, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Comment thread providers/anthropic/src/airflow/providers/anthropic/hooks/anthropic.py Outdated
Comment thread providers/anthropic/src/airflow/providers/anthropic/hooks/anthropic.py Outdated
Comment thread providers/anthropic/tests/unit/anthropic/hooks/test_anthropic.py Outdated
yuyua9 and others added 2 commits September 17, 2026 03:32
Invalid workload identity configuration currently surfaces a raw KeyError, making connection setup failures harder to diagnose.
@kaxil
kaxil force-pushed the fix/anthropic-wif-missing-fields-yuyua9 branch from 2423659 to 08e5dbe Compare September 17, 2026 02:33
@shahar1
shahar1 merged commit 24ff1f5 into apache:main Sep 18, 2026
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants