Fix DeadlockImminentError in async Connection resolution - #72079
Closed
saitejabandaru-in wants to merge 1 commit into
Closed
saitejabandaru-in wants to merge 1 commit into
saitejabandaru-in wants to merge 1 commit into
Conversation
When fetching a connection in an async context, `Connection.async_get()` builds the connection and caches its URI. The sync `get_uri()` internally accesses `extra_dejson`, which parses and masks secrets using a synchronous IPC call (`mask_secret`), thereby blocking the async event loop and throwing `DeadlockImminentError`.\n\nThis adds `aextra_dejson` and `aget_uri` coroutines to `Connection` that use the asynchronous `amask_secret` variant, and updates the task execution context to await `aget_uri` when caching.
saitejabandaru-in
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
August 25, 2026 21:16
Contributor
|
@saitejabandaru can you fix CI ? |
Member
|
Duplicate of #71890 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71891.
Motivation
A
DeadlockImminentErroris raised in Airflow 3 when resolving a connection inside an async task (e.g. viaawait BaseHook.aget_hook(...)). TheConnection.async_get()method resolves the connection and saves it toSecretCache. The cache attempts to save the URI via the synchronousget_uri()method, which deserializesextrausingextra_dejson.The
extra_dejsonproperty iteratively loops over the dict and masks secrets usingmask_secret, which triggers a synchronous IPC call (comms.send()) to the task supervisor. Since this executes inside the asyncio event-loop thread, it throwsDeadlockImminentErrorand crashes the loop.Changes
aextra_dejsonandaget_urionConnectionto do the same but natively await the existing async masking utility (amask_secret)._async_get_connectionin the execution environment's context toawait conn.aget_uri()when saving to the SecretCache.