Remove stale is_async docstring param from await_pod_start - #72261
Merged
Merged
Conversation
The function determines async mode internally via isinstance check rather than accepting an is_async parameter, so the docstring was describing an argument that doesn't exist in the signature.
ColtenOuO
marked this pull request as ready for review
August 29, 2026 14:55
ColtenOuO
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
August 29, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sumarry
The function determines async mode internally via isinstance check rather than accepting an is_async parameter, so the docstring was describing an argument that doesn't exist in the signature.
Change
Remove the
:param is_async:No any behavior be changed.