Conversation
Synchronous Batch tasks can submit a duplicate remote job when a worker crashes after submission but before completion. Reconnecting from task state keeps retries attached to the original job. Generated-by: GitHub Copilot CLI (GPT-5.6 Sol) Signed-off-by: 1fanwang <1fannnw@gmail.com>
Aged-out AWS Batch jobs otherwise leave every Airflow retry failing before a replacement can be submitted. Generated-by: GitHub Copilot CLI (GPT-5.6 Sol) Signed-off-by: 1fanwang <1fannnw@gmail.com>
|
Hello @1fanwang - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 34 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Synchronous
BatchOperatortasks always submit a new AWS Batch job when a worker retry starts. If the first worker dies after submission, the retry can run the same workload twice.This change uses AIP-103 task state to persist the Batch job ID before polling. A retry reconnects to active jobs, finalizes successful jobs without resubmitting, and submits a new job after a terminal failure. If AWS no longer returns the stored job, the retry submits a replacement after the existing status retries are exhausted. Other AWS API errors still propagate. Deferrable tasks and
wait_for_completion=Falsekeep their existing submission paths.Testing
Crash/retry proof with task state
The temporary proof script loaded the operator from
upstream/mainand the updated operator, then ran each twice with the realTaskStateStoreAccessor, local supervisor communication, and local AWS hook/waiter stand-ins.Aged-out job regression
Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI (GPT-5.6 Sol) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.