Fix collection error and timeout assertion in Snowpark container tests - #72709
Merged
potiuk merged 1 commit intoSep 8, 2026
Merged
Conversation
The deferrable-mode change reached for itertools.count without importing itertools, so the whole test module fails to collect and every check that scans all files goes red. Its timeout test also advanced the clock past the deadline before the first poll, so the operator logged no status at all and the assertion on the last observed status could never hold.
potiuk
approved these changes
Sep 8, 2026
Member
|
Thanks @henry3260 ! |
1 task
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
apache#72709) The deferrable-mode change reached for itertools.count without importing itertools, so the whole test module fails to collect and every check that scans all files goes red. Its timeout test also advanced the clock past the deadline before the first poll, so the operator logged no status at all and the assertion on the last observed status could never hold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is currently broken by this: the module fails to collect, so the ruff and
mypy jobs go red on every open PR, not only ones touching Snowflake. Example
run: https://github.com/apache/airflow/actions/runs/34225812873/job/102064432010
Fixing the import surfaces a second problem from the same change, so both are
here together. Fixing only the import would turn the collection error into two
test failures.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.