Conversation
Lee-W
force-pushed
the
common-ai-supported-services-page
branch
3 times, most recently
from
September 17, 2026 09:25
a5292df to
5479098
Compare
Lee-W
marked this pull request as ready for review
September 17, 2026 09:26
Member
|
@Lee-W Screenshots would be very helpful |
Lee-W
force-pushed
the
common-ai-supported-services-page
branch
from
September 18, 2026 08:00
5479098 to
0595000
Compare
Member
Author
|
kaxil
reviewed
Sep 18, 2026
Lee-W
force-pushed
the
common-ai-supported-services-page
branch
from
September 19, 2026 01:27
0595000 to
9c161ee
Compare
Lee-W
marked this pull request as draft
September 19, 2026 07:54
Lee-W
marked this pull request as ready for review
September 19, 2026 07:56
kaxil
requested changes
Sep 20, 2026
kaxil
left a comment
Member
There was a problem hiding this comment.
One thing I am concerned about is -- "toolsets" is the concept of Common AI provider and doesn't apply more generally to other providers. So calling it toolsets is weird.
I wonder if you can do something specific to only Common AI provider for now.. even if needs to be manually maintained (ideally not)
Lee-W
marked this pull request as draft
September 20, 2026 23:34
Readers had no single place to see what this provider reaches. The answer was spread across the toolsets guide, the index page, seven connection pages and provider.yaml, so the differentiating half — the Airflow hooks, MCP servers, SQL warehouses, DataFusion tables, sandboxes and vendor-managed agents a toolset gives you over a raw SDK call — was effectively unwritten. The model list had also drifted. It was a hand-copied snapshot of nine vendors while the connection actually resolves anything pydantic_ai.providers can construct, so services we already support, Snowflake Cortex and OpenRouter among them, were absent from the page a customer searches. Making provider.yaml the one source both the page and the registry read keeps them from disagreeing, and a test that derives the reachable set from pydantic-ai turns a drift into a red build naming the vendor rather than a quiet omission. That list is derived from a current pydantic-ai, while the provider supports pydantic-ai-slim from 2.23.0 upward and CI exercises exactly that floor. Snowflake Cortex and Crusoe reach back only to 2.27.0 and 2.28.0, so a vendor being absent downstream is a version difference rather than drift. The test therefore asserts on every supported version that an installed vendor is declared, and defers the opposite direction to the release that carries all of them.
Lee-W
force-pushed
the
common-ai-supported-services-page
branch
from
September 21, 2026 12:47
9c161ee to
a04ddd2
Compare
This was referenced Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Nothing told a user what
common.aiactually reaches — the answer was spread across the toolsets guide, the index page, seven connection pages andprovider.yaml, so the differentiating half (the Airflow hooks, MCP servers, SQL warehouses, DataFusion tables, sandboxes and vendor-managed agents a toolset gives you over a raw SDK call) was effectively unwritten.The model list had also drifted: it was a hand-copied snapshot of nine vendors while the connection resolves anything
pydantic_ai.providerscan construct, so services we already support — Snowflake Cortex and OpenRouter among them — were absent from the page a customer searches.What
provider.yamlbecomes the one source the docs page reads, and — for connection types — the registry too.pydanticaiandmcpconnection types get theirexternal-serviceslists completed, and a newtoolsets[].external-serviceskey (schema entry plus a section in the provider-hook-migration contributing doc) records what each toolset module reaches.provider-connection-servicesandprovider-toolset-services, render those lists as tables on a new Supported services page, linked from the provider indextoolsets.rstgainshowto/toolset:<module>anchors so every row links to the toolset it names.Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.