Skip to content

Fix FAB FastAPI PATCH users to respect FAB_PASSWORD_HASH_METHOD #73110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
Sep 14, 2026
+5 −8
Merged

Fix FAB FastAPI PATCH users to respect FAB_PASSWORD_HASH_METHOD #73110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions providers/fab/src/airflow/providers/fab/auth_manager/api_fastapi/services/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

from fastapi import HTTPException, status
from sqlalchemy import func, select
from werkzeug.security import generate_password_hash

from airflow.providers.fab.auth_manager.api_fastapi.datamodels.roles import Role
from airflow.providers.fab.auth_manager.api_fastapi.datamodels.users import (
Expand Down Expand Up @@ -188,7 +187,7 @@ def update_user(cls, username: str, body: UserPatchBody, update_mask: str | None

password_changed = False
if "password" in fields_to_update and body.password is not None:
user.password = generate_password_hash(body.password.get_secret_value())
user.password = security_manager._hash_password(body.password.get_secret_value())
password_changed = True

if "username" in fields_to_update and body.username is not None:
Expand Down
10 changes: 4 additions & 6 deletions providers/fab/tests/unit/fab/auth_manager/api_fastapi/services/test_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,14 +556,12 @@ def test_update_user_with_password(self, get_fab_auth_manager, fab_auth_manager,
password=password_mock,
)

with patch(
"airflow.providers.fab.auth_manager.api_fastapi.services.users.generate_password_hash"
) as mock_hash:
mock_hash.return_value = "hashed_password"
FABAuthManagerUsers.update_user("alice", patch_body, update_mask="password")
security_manager._hash_password.return_value = "hashed_password"
FABAuthManagerUsers.update_user("alice", patch_body, update_mask="password")

password_mock.get_secret_value.assert_called_once()
mock_hash.assert_called_once_with("newpassword")
security_manager._hash_password.assert_called_once_with("newpassword")
assert user_obj.password == "hashed_password"

# delete_user tests

Expand Down