Demote ADC credential log from info to debug - #73199
Merged
shahar1 merged 1 commit intoSep 19, 2026
Merged
Conversation
The `google.auth.default()` notice was emitted at INFO on every credential resolution, spamming logs for users on ADC-based setups like Cloud Composer where ADC is the expected auth method. Debug level matches the other credential resolution paths in this class and keeps the message available for auth troubleshooting.
SameerMesiah97
approved these changes
Sep 15, 2026
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
Approved pending green CI
shahar1
approved these changes
Sep 15, 2026
shahar1
left a comment
Contributor
There was a problem hiding this comment.
CC: @VladaZakharova / @MaksYermak - what do you think?
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #73163.
The
google.auth.default()notice in_CredentialProvider._get_credentials_using_adcwas emitted at INFO level on every credential resolution. For users on ADC-based setups like Cloud Composer, where ADC is the expected auth method, this spammed the logs on every connection lookup (e.g. eachhook.run()in a loop).This change demotes the message to DEBUG, matching the other credential resolution paths in the same class (
key_path,keyfile_dict,key_secret_nameall log at DEBUG). The message remains available for auth troubleshooting at DEBUG level.Test update:
test_get_credentials_and_project_id_with_default_authnow captures at DEBUG level to match.