Fix DataFusion storage-type error message on Python 3.11+ - #73413
Merged
Merged
Conversation
The scheduled CI run on main fails the common.sql datafusion object storage tests on Python 3.11 through 3.14. `StorageType` is a `str, Enum` mixin, and starting with Python 3.11 `Enum.__format__` renders such members as `StorageType.GCS` instead of `gcs`, so the "connection_config must be provided" messages no longer name the storage type users configure. The PR that introduced the f-strings only ran on the default Python 3.10, where the value is rendered. Generated-by: Claude Opus 5
amoghrajesh
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled
Tests (AMD)run onmain(https://github.com/apache/airflow/actions/runs/35515068767) failstest_gcs_provider_requires_connection_configandtest_s3_provider_requires_connection_configin the common.sql DataFusion object storage provider on Python 3.11, 3.12, 3.13 and 3.14, in both the Non-DB providers and the lowest-deps provider jobs.StorageTypeis astr, Enummixin. Starting with Python 3.11,Enum.__format__renders such members asStorageType.GCSrather than the valuegcs, so theconnection_config must be provided for ...messages stopped naming the storage type users actually configure. The f-strings were introduced in #73296, whose PR CI only ran on the default Python 3.10 where the value is still rendered, so the regression surfaced in the canary run.Formatting
.valuerestores the intended message on every supported Python version. Verified locally: the two tests fail on Python 3.12 before this change and pass on Python 3.10 and 3.12 after it.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5.1) following the guidelines
🤖 Generated with Claude Code