Stop docs builds from importing example Dags to highlight them - #73604
Merged
Merged
Conversation
ashb
approved these changes
Sep 23, 2026
ashb
left a comment
Member
There was a problem hiding this comment.
Sounds sensible if it works. Thanks!
1 task
Contributor
Author
|
Alright rebased, lets see how it goes. |
ashb
force-pushed
the
fix-example-include
branch
from
September 23, 2026 16:34
eeeac49 to
0184af0
Compare
Contributor
Author
|
Guess it does. Merging |
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 24, 2026
… them (apache#73604) (cherry picked from commit 74d1a3b) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 24, 2026
… them (apache#73604) (cherry picked from commit 74d1a3b) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Sphinx's
ModuleAnalyzer.for_module()locates a module's source by importing it. The examples rendered by the exampleinclude directive live in providertests/systemtrees that are not / should not be importable during a docs build.Noticed this error earlier today on #70960
The import buys nothing here: doctree_read already knows the file on disk, and Sphinx offers
for_file()to tokenize it directly.Ref: https://github.com/sphinx-doc/sphinx/blob/b04a2101295ac3fb725b16111eda0284b6da4cca/sphinx/pycode/__init__.py#L89-L103
Tested it works fine after doc build:
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.