Skip to content

feat: add more spans to opentelemetry plugin #12686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

feat: add more spans to opentelemetry plugin #12686

wants to merge 26 commits into from
+830 −42

Conversation

@nic-6443
Copy link
Member

@nic-6443 nic-6443 commented Oct 19, 2025 •
edited by Revolyssup
Loading

Description

Run jaeger in local by https://www.jaegertracing.io/docs/2.11/getting-started/#all-in-one

image screenshot-2025-10-24_12-32-41

Which issue(s) this PR fixes:

Fixes #

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

nic-6443
nic-6443 commented Oct 20, 2025
View reviewed changes
apisix/core/response.lua
end

if code then
if code >= 400 then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, we would need to add a tracer.finish_current_span call in every core.response.exit() code, which is very troublesome.

nic-6443
nic-6443 commented Oct 22, 2025
View reviewed changes
apisix/utils/span.lua
}


function _M.new(name, kind)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: reuse span table if there has any proformance issue.

@Revolyssup Revolyssup marked this pull request as ready for review October 23, 2025 14:21
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Oct 23, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 23, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 23, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 24, 2025
@Revolyssup Revolyssup requested review from membphis, moonming and nic-chen and removed request for membphis October 25, 2025 20:19
Revolyssup
Revolyssup previously approved these changes Oct 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Revolyssup Revolyssup Revolyssup left review comments

@moonming moonming Awaiting requested review from moonming

@membphis membphis Awaiting requested review from membphis

@nic-chen nic-chen Awaiting requested review from nic-chen

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nic-6443 @Revolyssup