Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-625: Map MinorType getNewFieldWriter returns UnionMapWriter #627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-625: Map MinorType getNewFieldWriter returns UnionMapWriter #627

wants to merge 1 commit into from

Conversation

wsuppiger
Copy link

What's Changed

Closes #625

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@lidavidm lidavidm added the bug-fix PRs that fix a big. label Feb 21, 2025
lidavidm
lidavidm reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would it be possible to add a unit test somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm left review comments

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

Assignees
No one assigned
Labels
bug-fix PRs that fix a big.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getNewFieldWriter returns UnionListWriter instead of UnionMapWriter
2 participants
@wsuppiger @lidavidm