Skip to content

Conversation

axreldable
Copy link

@axreldable axreldable commented Oct 12, 2025

What's Changed

UnionMapWriter will null out the entire map struct entry instead of setting the value to null in:

childWriter.value().fixedSizeBinary().writeNull();

This PR overrides the fixedSizeBinary method for the UnionMapWriter, resolving it.

Closes #586.

This comment has been minimized.

@axreldable axreldable marked this pull request as ready for review October 12, 2025 14:48
@axreldable
Copy link
Author

axreldable commented Oct 12, 2025

Thank you for opening a pull request!

Please label the PR with one or more of:

  • bug-fix
  • chore
  • dependencies
  • documentation
  • enhancement

Also, add the 'breaking-change' label if appropriate.

See CONTRIBUTING.md for details.

Hm, looks like I don't have enough permissions to add labels.

Could the maintainers add the bug-fix label, please?

@axreldable
Copy link
Author

Hi @nbauernfeind! It's my attempt to address the issue you opened. Could you please take a look? Is it what you had in mind for it?

@axreldable
Copy link
Author

Hi @lidavidm , @jbonofre! Could you please check this? Or at least add the bug-fix label to ensure PR format to release CI build. Thank you!

@jbonofre
Copy link
Member

@axreldable sure. I will. FYI we are working on fixing the CI right now. Your PR will probably need a rebase as soon as CI is green again. I will keep you posted.

@jbonofre jbonofre added the bug-fix PRs that fix a big. label Oct 14, 2025
@github-actions github-actions bot added this to the 18.4.0 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change bug-fix PRs that fix a big.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnionMapWriter fails to write fixed size binary

2 participants