fix: Encoded an array of type Struct([])
#7419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
changed the title
Struct([])
alamb
reviewed
May 5, 2025
| true => (rows.row(idx), 0x01), | ||
| false => (*null, null_sentinel), | ||
| let (row, sentinel) = if array.is_valid(idx) { | ||
| let row = if rows.num_rows() == 0 { |
There was a problem hiding this comment.
I am worried about adding a new test on each row of the conversion as that may slow down things significantly
I think we could check if the input array's size was greater than zero and just ignore the offsets if not
let array = as_struct_array(column);
if array.len() == 0 {
return OK(())
}Or something
| let back = converter.convert_rows(&r).unwrap(); | ||
| assert_eq!(back.len(), 1); | ||
| assert_eq!(&back[0], &s); | ||
| } |
There was a problem hiding this comment.
Can you also verify we have tests covering empty arrays of other offset based types (such as ListArray, StringArray, etc) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RowConverter::convert_columnspanics when encodingStruct([])#7168Rationale for this change
Check the length of the rows when encoding the column
What changes are included in this PR?
Are there any user-facing changes?
No