Add arrow_reader_clickbench
benchmark
#7470
Draft
+672
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We are trying to improve the performance of row filter application in the Parquet arrow reader and part of that is a benchmark that we can use to guide optimization efforts.
However, as discussed in #7428 the
arrow_reader_row_filter
microbenchmark doesn't currently reflect the actual performance we see in our end to end application (DataFusion).Thus, we think we need to create a benchmark that uses the actual ClickBench dataset with appropriate filtering
What changes are included in this PR?
arrow_reader_clickbench
benchmarkThis benchmark tests applying the actual clickbench filters (and column materialization):
Are there any user-facing changes?
New benchmark, and hopefully thus improved filter / projection performance
TODO