Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump .ruby-version from 3.0.6 to 3.3.6 #566

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Nov 30, 2024

This repo includes a .ruby-version file and the Gemfile refers to this. The site can be built with other Ruby versions but:

  1. I think It's best to keep whatever version we specify in .ruby-version to something that's in support. Ruby 3.0.6 is not.
  2. Our GHA workflows use ruby/setup-ruby which uses the Ruby version specified in .ruby-version which is another reason to specify an in support version of Ruby

I chose Ruby 3.3.6 because it's the latest release as of writing.

I've tested this PR locally by:

  • Bundling under Ruby 3.3.6
  • Generating the site (bundle exec generate)

And all looks good.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou any concerns?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

No concern! If we have any problem, I can fix them.

@kou kou merged commit 7132d4b into apache:main Nov 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants