Describe the enhancement requested
Several of the DictionaryArray accessor methods (dictionary() and indices()) currently return a std::shared_ptr<Arrray by value. From looking at the implementation, these underlying arrays are owned by the class so it seems possible to return them as a const std::shared_ptr<Array>& instead - keeping with general conventions and reducing potential gotchas.
Component(s)
C++
Describe the enhancement requested
Several of the
DictionaryArrayaccessor methods (dictionary()andindices()) currently return astd::shared_ptr<Arrrayby value. From looking at the implementation, these underlying arrays are owned by the class so it seems possible to return them as aconst std::shared_ptr<Array>&instead - keeping with general conventions and reducing potential gotchas.Component(s)
C++