-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45522: [Parquet][C++] Parquet GEOMETRY and GEOGRAPHY logical type implementations #45459
Open
paleolimbot
wants to merge
150
commits into
apache:main
Choose a base branch
from
paleolimbot:Kontinuation-kontinuation-parquet-geometry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GH-45522: [Parquet][C++] Parquet GEOMETRY and GEOGRAPHY logical type implementations #45459
paleolimbot
wants to merge
150
commits into
apache:main
from
paleolimbot:Kontinuation-kontinuation-parquet-geometry
+7,225
−2,405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gang Wu <[email protected]>
Is it possible to add new examples instead of creating a new branch? It is much simpler to link rapidjson to these example executables. Test files are also reproducible in this approach.
I'm fine with this given that the integration is trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The GEOMETRY and GEOGRAPHY logical types are being proposed as an addition to the Parquet format.
What changes are included in this PR?
This is a continuation of @Kontinuation 's initial PR (#43977) implementing apache/parquet-format#240 , which included:
Changes after this were:
In order to write test files, I also:
Those last two are probably a bit much for this particular PR, and I'm happy to move them.
Some things that aren't in this PR (but should be in this one or a future PR):
max > min
(and generally make sure the stats for geography are written for trivial cases)Are these changes tested?
Yes!
Are there any user-facing changes?
Yes!
Example from the included Python bindings: